-
Notifications
You must be signed in to change notification settings - Fork 198
fix(teams): Restore member management in new ui #4607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4607 +/- ##
============================================
- Coverage 10.56% 10.35% -0.21%
Complexity 265 265
============================================
Files 123 123
Lines 5767 5881 +114
Branches 1262 1296 +34
============================================
Hits 609 609
- Misses 5035 5149 +114
Partials 123 123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a0650ed to
caaae96
Compare
AIlkiv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also correct the key attribute, because when members are deleted, the index changes.
<MemberGridItem v-for="(member, index) in flatList"
:key="`member-grid-item-${index}`"
member-grid-item-${index} to member-grid-item-${member.id}
The demo shows that the menu moves on to the next member.
2.mp4
caaae96 to
ae3a4a7
Compare
ae3a4a7 to
8e1d2de
Compare
|
@nfebe To:
CSS:
|
AIlkiv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the good work.
Signed-off-by: nfebe <[email protected]>
Signed-off-by: nfebe <[email protected]>
Signed-off-by: nfebe <[email protected]>
- Add media queries for mobile views - Add members roles to their cards in the grid Signed-off-by: nfebe <[email protected]>
54fdeaa to
a83142e
Compare








Screenshots
Manage members (leave, delete, promote)
Accept reject (leave, delete, promote)
Resolves: #4600