Skip to content

Conversation

@nfebe
Copy link
Contributor

@nfebe nfebe commented Aug 8, 2025

  • Restore ability to leave teams
  • Restore ability for admins to reject/approve new team members

Screenshots

Manage members (leave, delete, promote)

image

Accept reject (leave, delete, promote)

image

Resolves: #4600

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 0% with 99 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.35%. Comparing base (38aef0c) to head (a83142e).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/components/MemberList/MemberGridItem.vue 0.00% 99 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4607      +/-   ##
============================================
- Coverage     10.56%   10.35%   -0.21%     
  Complexity      265      265              
============================================
  Files           123      123              
  Lines          5767     5881     +114     
  Branches       1262     1296      +34     
============================================
  Hits            609      609              
- Misses         5035     5149     +114     
  Partials        123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nfebe nfebe force-pushed the enh/4600/leftover-new-teams-management-ui branch from a0650ed to caaae96 Compare August 8, 2025 11:59
@nfebe nfebe requested review from AIlkiv, marcoambrosini and skjnldsv and removed request for hamza221 August 8, 2025 12:00
@nfebe nfebe added 3. to review Waiting for reviews feature: teams ex circles skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills labels Aug 8, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 📁 Files team Aug 8, 2025
Copy link
Contributor

@AIlkiv AIlkiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also correct the key attribute, because when members are deleted, the index changes.

<MemberGridItem v-for="(member, index) in flatList"
				:key="`member-grid-item-${index}`"

member-grid-item-${index} to member-grid-item-${member.id}

The demo shows that the menu moves on to the next member.

2.mp4

@nfebe nfebe force-pushed the enh/4600/leftover-new-teams-management-ui branch from caaae96 to ae3a4a7 Compare August 15, 2025 17:38
@nfebe nfebe requested a review from AIlkiv August 15, 2025 17:38
@nfebe nfebe force-pushed the enh/4600/leftover-new-teams-management-ui branch from ae3a4a7 to 8e1d2de Compare August 15, 2025 17:51
@AIlkiv
Copy link
Contributor

AIlkiv commented Aug 15, 2025

@nfebe
Please add media queries CSS for mobile.

From:
Image

To:

Image

CSS:

Image Image

@AIlkiv
Copy link
Contributor

AIlkiv commented Aug 15, 2025

I think it makes sense to show the level (owner/admin/moderator/member).

image

Changes in the browser:

image

@nfebe
Copy link
Contributor Author

nfebe commented Aug 15, 2025

Desktop Mobile
image image

Copy link
Contributor

@AIlkiv AIlkiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good work.

@nfebe nfebe force-pushed the enh/4600/leftover-new-teams-management-ui branch from 54fdeaa to a83142e Compare August 16, 2025 10:13
@nfebe nfebe merged commit 45ed4e9 into main Aug 16, 2025
42 of 44 checks passed
@nfebe nfebe deleted the enh/4600/leftover-new-teams-management-ui branch August 16, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: teams ex circles skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

enh: Improvements for new teams management UI

3 participants