Skip to content

Conversation

@leftybournes
Copy link
Contributor

@leftybournes leftybournes commented Aug 28, 2025

Allow a user to view their groups through the teams menu. Groups can only be viewed by its members.
Reference issue here nextcloud/circles#1941

Requires nextcloud/server#54691 to be merged first

image

Allow a user to view their groups through the teams menu. Groups can
only be viewed by its members.

Signed-off-by: Kent Delante <[email protected]>
@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 0% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 9.60%. Comparing base (66f0ea1) to head (16b6be5).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/components/UserGroupDetails.vue 0.00% 31 Missing ⚠️
...rc/components/UserGroupDetails/UserGroupMember.vue 0.00% 22 Missing ⚠️
src/components/AppContent/CircleContent.vue 0.00% 10 Missing ⚠️
src/components/AppNavigation/RootNavigation.vue 0.00% 5 Missing ⚠️
src/views/Contacts.vue 0.00% 5 Missing ⚠️
src/mixins/RouterMixin.js 0.00% 2 Missing ⚠️
.../components/AppNavigation/CircleNavigationItem.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #4658       +/-   ##
============================================
- Coverage     65.71%   9.60%   -56.11%     
  Complexity      266     266               
============================================
  Files            26     128      +102     
  Lines           773    6400     +5627     
  Branches          0    1189     +1189     
============================================
+ Hits            508     615      +107     
- Misses          265    5664     +5399     
- Partials          0     121      +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leftybournes leftybournes added enhancement New feature or request 3. to review Waiting for reviews labels Aug 28, 2025
methods: {
async fetchMemberInfo() {
const user = encodeURIComponent(this.member)
const { data } = await axios.post(generateUrl('contactsmenu/findOne'), `shareType=0&shareWith=${user}`)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this. I couldn't find a better way to get a user's details.

Copy link
Contributor

@hamza221 hamza221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Only thing is that I get a 403 when accessing the group as a non admin
ocs/v2.php/cloud/groups/{name}/users

Edit: was missing server update

@hamza221
Copy link
Contributor

hamza221 commented Sep 3, 2025

Also I'm not sure if admins are supposed to see all the groups or just the user groups where they're admin

Edit: checked with Andy and should be okay for a first iteration

@AndyScherzinger
Copy link
Member

Also I'm not sure if admin are supposed to see all the groups or just the user groups where they're admin

Nextcloud admin, sees all LDAP groups, hence fine to see all "read-only-exposed teams equivalent LDAP groups"

@hamza221 hamza221 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 3, 2025
@AndyScherzinger AndyScherzinger merged commit dc44271 into main Sep 3, 2025
34 of 36 checks passed
@AndyScherzinger AndyScherzinger deleted the teams_groups_readonly branch September 3, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants