-
Notifications
You must be signed in to change notification settings - Fork 199
feat: show a user's groups as teams #4658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Allow a user to view their groups through the teams menu. Groups can only be viewed by its members. Signed-off-by: Kent Delante <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4658 +/- ##
============================================
- Coverage 65.71% 9.60% -56.11%
Complexity 266 266
============================================
Files 26 128 +102
Lines 773 6400 +5627
Branches 0 1189 +1189
============================================
+ Hits 508 615 +107
- Misses 265 5664 +5399
- Partials 0 121 +121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| methods: { | ||
| async fetchMemberInfo() { | ||
| const user = encodeURIComponent(this.member) | ||
| const { data } = await axios.post(generateUrl('contactsmenu/findOne'), `shareType=0&shareWith=${user}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this. I couldn't find a better way to get a user's details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Only thing is that I get a 403 when accessing the group as a non admin
ocs/v2.php/cloud/groups/{name}/users
Edit: was missing server update
|
Also I'm not sure if admins are supposed to see all the groups or just the user groups where they're admin Edit: checked with Andy and should be okay for a first iteration |
Nextcloud admin, sees all LDAP groups, hence fine to see all "read-only-exposed teams equivalent LDAP groups" |
Allow a user to view their groups through the teams menu. Groups can only be viewed by its members.
Reference issue here nextcloud/circles#1941
Requires nextcloud/server#54691 to be merged first