Skip to content

clone stacks #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakobroehrl wants to merge 10 commits into from
Closed

clone stacks #1777

jakobroehrl wants to merge 10 commits into from

Conversation

@jakobroehrl
Copy link
Contributor

@jakobroehrl jakobroehrl commented Apr 29, 2020 •
edited
Loading

Signed-off-by: Jakob Röhrl [email protected]

Todo / to clarify

  • Ideally we get the number of stacks in total for the board and move it to the end.
  • We could use the card clone implementation and use it here, too: Clone / Copy boards [$150] #119 (comment)
  • labels and assigned users clone
  • I think it should also work to just operate on $card directly so you just overwrite the properties that need to be changed and then passed to insert afterwards.
  1. Labels are only shown after page reload
  2. User assignment doesn't work: "The user is not part of the board"
    https://github.com/nextcloud/deck/blob/0dd38f5f2e067ef78aa7dbf3cfc8cb61c6d2d6ca/lib/Service/StackService.php#L451-L455

@jakobroehrl jakobroehrl added this to the ⭐ 1.1.0 milestone Apr 29, 2020
@jakobroehrl jakobroehrl requested a review from juliusknorr April 29, 2020 11:01
@jakobroehrl jakobroehrl self-assigned this Apr 29, 2020
@jakobroehrl
Copy link
Contributor Author

jakobroehrl commented Apr 30, 2020

@juliushaertl
We could use the card clone implementation and use it here, too: #119 (comment)
What do you think?

@stefan-niedermann
Copy link
Member

stefan-niedermann commented May 9, 2020 •
edited
Loading

Please have a look at #1832 before you make exact clones of the cards @jakobroehrl (Not sure if this affects this issue, sorry for spam if not)

juliusknorr
juliusknorr reviewed May 14, 2020
View reviewed changes
juliusknorr
juliusknorr reviewed May 14, 2020
View reviewed changes
juliusknorr
juliusknorr reviewed May 14, 2020
View reviewed changes
lib/Service/StackService.php Outdated
$newStack = new Stack();
$newStack->setTitle($stack->getTitle() . ' (' . $this->l10n->t('copy') . ')');
$newStack->setBoardId($boardId);
$newStack->setOrder($stack->getOrder() +1);
Copy link
Member

@juliusknorr juliusknorr May 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we get the number of stacks in total for the board and move it to the end.

Copy link
Contributor Author

@jakobroehrl jakobroehrl May 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. This way I'll get the corresponding board:
$board = $this->boardMapper->find($boardId);
How can I get the stack number of this board?

This comment was marked as resolved.

Sign in to view

juliusknorr
juliusknorr reviewed May 14, 2020
View reviewed changes
juliusknorr
juliusknorr reviewed May 14, 2020
View reviewed changes
juliusknorr
juliusknorr reviewed May 14, 2020
View reviewed changes
juliusknorr
juliusknorr reviewed May 14, 2020
View reviewed changes
juliusknorr
juliusknorr reviewed May 14, 2020
View reviewed changes
@jakobroehrl jakobroehrl force-pushed the enh/cloneStack branch 2 times, most recently from ee0d103 to 7c00309 Compare May 15, 2020 07:14
@jakobroehrl jakobroehrl requested a review from juliusknorr May 15, 2020 07:17
@jakobroehrl jakobroehrl force-pushed the enh/cloneStack branch 5 times, most recently from 0dd38f5 to 1dce89e Compare May 19, 2020 06:09
juliusknorr
juliusknorr reviewed Jun 10, 2020
View reviewed changes
lib/Db/AssignedLabelsMapper.php Outdated
Copy link
Member

@juliusknorr juliusknorr Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for that, you should be able to just remove the whole insert method and it will use the parent one then.

@ricstg

This comment has been minimized.

Sign in to view
@jakobroehrl jakobroehrl mentioned this pull request Jun 17, 2020
Closed
@jakobroehrl
Copy link
Contributor Author

jakobroehrl commented Jun 18, 2020

Works great!
Let's merge this in, so I can work on the board clone and card clone topics:

juliusknorr
juliusknorr reviewed Jun 23, 2020
View reviewed changes
juliusknorr
juliusknorr requested changes Jun 23, 2020
View reviewed changes
lib/Service/StackService.php Outdated
$newStack = new Stack();
$newStack->setTitle($stack->getTitle() . ' (' . $this->l10n->t('copy') . ')');
$newStack->setBoardId($boardId);
$newStack->setOrder($stack->getOrder() +1);

This comment was marked as resolved.

Sign in to view

juliusknorr
juliusknorr reviewed Sep 2, 2020
View reviewed changes
lib/Db/AssignedLabelsMapper.php
* @return array|Entity
*/
public function find($cardId) {
$sql = 'SELECT * from `*PREFIX*deck_assigned_labels` where `card_id` = ?';
Copy link
Member

@juliusknorr juliusknorr Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be switched to QBMapper right away to get rid of the deprecated DeckMapper. See https://docs.nextcloud.com/server/18/developer_manual/app/storage/database.html?highlight=querybuilder#mappers for an example

Copy link
Member

@juliusknorr juliusknorr Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to do that in a follow up, but it would be good to not introduce new code that uses legacy functions right away 😉

@jakobroehrl
security and api
2a4b0a3 
Signed-off-by: Jakob Röhrl <[email protected]>
juliusknorr
juliusknorr reviewed Sep 4, 2020
View reviewed changes
@jakobroehrl
format json
14d90e2 
Signed-off-by: Jakob Röhrl <[email protected]>
@juliusknorr
Copy link
Member

juliusknorr commented Sep 8, 2020

Tests fail 😉

@jakobroehrl jakobroehrl force-pushed the enh/cloneStack branch 3 times, most recently from 4a23abb to 2a8841f Compare September 16, 2020 07:03
@jakobroehrl
test adjustments
24f83b8 
Signed-off-by: Jakob Röhrl <[email protected]>
@juliusknorr juliusknorr mentioned this pull request Sep 17, 2020
Merged
@juliusknorr juliusknorr modified the milestones: ⭐ 1.1.0, 💥 1.2.0 Oct 2, 2020
juliusknorr
juliusknorr reviewed Oct 15, 2020
View reviewed changes
juliusknorr
juliusknorr reviewed Oct 15, 2020
View reviewed changes
@jakobroehrl
faq
caa201d 
Signed-off-by: Jakob Röhrl <[email protected]>
@jakobroehrl
test
6565069 
Signed-off-by: Jakob Röhrl <[email protected]>
@juliusknorr juliusknorr modified the milestones: 1.2.0, 1.3.0 Nov 10, 2020
@juliusknorr juliusknorr removed this from the 1.3.0 milestone Dec 29, 2020
@doodhout
Copy link

doodhout commented May 23, 2022

There was no reason given why this was never merged and then closed.

Is it possible to pick this up again, by the original committer or by someone else?

@agautheron
Copy link

agautheron commented Nov 8, 2024

Is it possible to pick this up again, by the original committer or by someone else?

@juliusknorr ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@jakobroehrl jakobroehrl

Labels

3. to review enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

clone a stack

7 participants

@jakobroehrl @stefan-niedermann @ricstg @juliusknorr @doodhout @agautheron