Skip to content

Conversation

@jakobroehrl
Copy link
Contributor

@jakobroehrl jakobroehrl commented May 11, 2020

Signed-off-by: Jakob Röhrl [email protected]

grafik

Signed-off-by: Jakob Röhrl <[email protected]>
@juliusknorr

This comment has been minimized.

@jakobroehrl jakobroehrl requested a review from juliusknorr May 13, 2020 10:14
@stefan-niedermann
Copy link
Member

I would switch the entries, like in the boards menu:

grafik

In general we should put the most destructive operations (delete in this case) always at the bottom (Files app does this, too).

@jakobroehrl jakobroehrl force-pushed the enh/archiveAllCardsFromStack branch from 0cea1c3 to 7e24cc9 Compare May 13, 2020 10:23
@jakobroehrl
Copy link
Contributor Author

In general we should put the most destructive operations (delete in this case) always at the bottom (Files app does this, too).

done

Signed-off-by: Jakob Röhrl <[email protected]>
Comment on lines 144 to 145
archiveAllCardsProgress: null,
stackLen: 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets group those into an object:

stackTransfer: {
  total: 0,
  current: null,
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakobroehrl What about this?

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

Signed-off-by: Jakob Röhrl <[email protected]>
@jakobroehrl jakobroehrl force-pushed the enh/archiveAllCardsFromStack branch from cefc792 to dea358e Compare August 18, 2020 06:09
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this 👍

@juliusknorr juliusknorr merged commit c0bfba7 into master Aug 18, 2020
@juliusknorr juliusknorr deleted the enh/archiveAllCardsFromStack branch August 18, 2020 06:17
@juliusknorr juliusknorr mentioned this pull request Sep 1, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to archive all tasks in a column?

4 participants