Skip to content

fix: Use strings as rich object ids #6898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 1 commit into from
Apr 28, 2025
Merged

fix: Use strings as rich object ids #6898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Use strings as rich object ids 
Signed-off-by: Julius Knorr <[email protected]>
  • Loading branch information
@juliusknorr
juliusknorr committed Apr 22, 2025
commit ea84743864e4feb267419282aa16a4d0c14e424b
32 changes: 16 additions & 16 deletions lib/Notification/Notifier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,21 +106,21 @@ public function prepare(INotification $notification, string $languageCode): INot
[
'deck-card' => [
'type' => 'deck-card',
'id' => $cardId,
'id' => (string)$cardId,
'name' => $params[0],
'boardname' => $params[1],
'boardname' => (string)$params[1],
'stackname' => $stack->getTitle(),
'link' => $this->getCardUrl($boardId, $cardId),
],
'deck-board' => [
'type' => 'deck-board',
'id' => $boardId,
'name' => $params[1],
'id' => (string)$boardId,
'name' => (string)$params[1],
'link' => $this->getBoardUrl($boardId),
],
'user' => [
'type' => 'user',
'id' => $params[2],
'id' => (string)$params[2],
'name' => $dn,
]
]
Expand All @@ -143,16 +143,16 @@ public function prepare(INotification $notification, string $languageCode): INot
[
'deck-card' => [
'type' => 'deck-card',
'id' => $cardId,
'name' => $params[0],
'boardname' => $params[1],
'id' => (string)$cardId,
'name' => (string)$params[0],
'boardname' => (string)$params[1],
'stackname' => $stack->getTitle(),
'link' => $this->getCardUrl($boardId, $cardId),
],
'deck-board' => [
'type' => 'deck-board',
'id' => $boardId,
'name' => $params[1],
'id' => (string)$boardId,
'name' => (string)$params[1],
'link' => $this->getBoardUrl($boardId),
],
]
Expand Down Expand Up @@ -181,15 +181,15 @@ public function prepare(INotification $notification, string $languageCode): INot
[
'deck-card' => [
'type' => 'deck-card',
'id' => $cardId,
'name' => $params[0],
'boardname' => $params[1],
'id' => (string)$cardId,
'name' => (string)$params[0],
'boardname' => (string)$params[1],
'stackname' => $stack->getTitle(),
'link' => $this->getCardUrl($boardId, $cardId),
],
'user' => [
'type' => 'user',
'id' => $params[2],
'id' => (string)$params[2],
'name' => $dn,
]
]
Expand Down Expand Up @@ -218,8 +218,8 @@ public function prepare(INotification $notification, string $languageCode): INot
[
'deck-board' => [
'type' => 'deck-board',
'id' => $boardId,
'name' => $params[0],
'id' => (string)$boardId,
'name' => (string)$params[0],
'link' => $this->getBoardUrl($boardId),
],
'user' => [
Expand Down