Label editing in board sidebar #935

jakobroehrl · 2019-03-12T09:30:33Z

Signed-off-by: Jakob Röhrl [email protected]

Resolves: #
Target version: master

Summary

TODO

Add color picker
Note the color type of input fields as we use it right now in the angular version doesn't work with safari, so feel free to hook in some color picker library for the custom colors like https://xiaokaike.github.io/vue-color/
We should move the sidebar to Implement sidebar component nextcloud-libraries/nextcloud-vue#340 once it is released to the nextcloud-vue package.
Properly style edit/delete buttons

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Documentation (manuals or wiki) has been updated or is not required

src/components/board/TagsTabSidebard.vue

juliusknorr · 2019-04-11T06:31:10Z

We should move the sidebar to Implement sidebar component nextcloud-libraries/nextcloud-vue#340 once it is released to the nextcloud-vue package.

moved to first post

src/services/BoardApi.js

juliusknorr · 2019-04-17T09:51:26Z

src/components/board/TagsTabSidebard.vue

+				<template v-if="editingLabelId === label.id">
+					<input v-model="editingLabel.title"><input v-model="editingLabel.color">
+					<button class="icon-checkmark" @click="updateLabel(label)" :disabled="!editLabelObjValidated" 
+					v-tooltip="{content: 'title and color must be provided', 


Please use a translatable string there

juliusknorr

@jakobroehrl Some minor comments. Besides that it looks good. 👍

src/components/board/TagsTabSidebard.vue

juliusknorr · 2019-04-17T09:58:21Z

@jakobroehrl I also updated the TODO list in the original post.

src/components/board/TagsTabSidebard.vue

juliusknorr · 2019-04-25T15:44:08Z

src/components/board/TagsTabSidebard.vue

+					<span :style="{ backgroundColor: `#${label.color}`, color:textColor(label.color) }" class="label-title">
+						<span v-if="label.title">{{ label.title }}</span><i v-if="!label.title"><br></i>
+					</span>
+					 <button v-tooltip="t('deck', 'Edit')" class="icon-rename" @click="clickEdit(label)" />


Suggested change

<button v-tooltip="t('deck', 'Edit')" class="icon-rename" @click="clickEdit(label)" />

<button v-tooltip="t('deck', 'Edit')" class="icon-rename" @click="clickEdit(label)" />

src/components/board/TagsTabSidebard.vue

juliusknorr · 2019-04-25T16:01:00Z

@jakobroehrl Looks good appart from my small change requests 👍 We definitely still need to do some polishing of the color picker, so that it properly fits into the sidebar, but I'm fine with doing that in a separate pull request. We should try to get this merged to the vue branch, and continue with the other sidebar tabs in separate pull requests.

juliusknorr · 2019-04-26T07:58:28Z

We definitely still need to do some polishing of the color picker, so that it properly fits into the sidebar

I've created a ColorPicker-Component in the vue branch, so we can just use that once we merged your branch back. 😉

Signed-off-by: Jakob Röhrl <[email protected]>

Signed-off-by: Michael Weimann <[email protected]>

Signed-off-by: Jakob Röhrl <[email protected]>

Signed-off-by: Julius Härtl <[email protected]>

Signed-off-by: Jakob Röhrl <[email protected]>

Signed-off-by: Julius Härtl <[email protected]>

juliusknorr · 2019-04-26T14:27:38Z

Thanks a lot for all the work @jakobroehrl 🎉

jakobroehrl requested a review from juliusknorr March 12, 2019 09:30

juliusknorr added the vue-migration label Mar 27, 2019

juliusknorr reviewed Apr 10, 2019

View reviewed changes

src/components/board/TagsTabSidebard.vue Outdated Show resolved Hide resolved

juliusknorr changed the title ~~first try~~ Label editing in board sidebar Apr 11, 2019

juliusknorr reviewed Apr 17, 2019

View reviewed changes

src/services/BoardApi.js Outdated Show resolved Hide resolved

juliusknorr reviewed Apr 17, 2019

View reviewed changes

juliusknorr requested changes Apr 17, 2019

View reviewed changes

src/components/board/TagsTabSidebard.vue Outdated Show resolved Hide resolved

src/components/board/TagsTabSidebard.vue Outdated Show resolved Hide resolved

jakobroehrl self-assigned this Apr 18, 2019

juliusknorr force-pushed the vue-board-sidebar branch from b3c569b to 6efca19 Compare April 23, 2019 19:58

jakobroehrl force-pushed the vue-board-sidebar branch from 6efca19 to b7383d2 Compare April 24, 2019 10:33

jakobroehrl requested a review from juliusknorr April 24, 2019 10:37

juliusknorr requested changes Apr 25, 2019

View reviewed changes

jakobroehrl and others added 7 commits April 26, 2019 15:39

first try

ec01ab4

Signed-off-by: Jakob Röhrl <[email protected]>

Add label handling to the main store

96ec6b8

Signed-off-by: Michael Weimann <[email protected]>

label update

b3cb618

Signed-off-by: Jakob Röhrl <[email protected]>

update, delete and create are working

1cd1684

Signed-off-by: Jakob Röhrl <[email protected]>

added picker, button update and small changes

49e1d8e

Signed-off-by: Jakob Röhrl <[email protected]>

Add working example of vue-multiselect

907bf57

Signed-off-by: Julius Härtl <[email protected]>

some small changes

3f272b9

Signed-off-by: Jakob Röhrl <[email protected]>

juliusknorr force-pushed the vue-board-sidebar branch from 7b25bdf to 3f272b9 Compare April 26, 2019 13:39

juliusknorr added 3 commits April 26, 2019 16:15

Fix styling of label sidebar

e7400fe

Signed-off-by: Julius Härtl <[email protected]>

Use sidebar component for board sidebar

b854015

Signed-off-by: Julius Härtl <[email protected]>

Run initial install on drone

643797d

Signed-off-by: Julius Härtl <[email protected]>

juliusknorr force-pushed the vue-board-sidebar branch from 5307ae9 to 643797d Compare April 26, 2019 14:25

juliusknorr approved these changes Apr 26, 2019

View reviewed changes

juliusknorr merged commit d32da10 into vue Apr 26, 2019

juliusknorr deleted the vue-board-sidebar branch April 26, 2019 14:27

This was referenced Oct 28, 2023

[Snyk] Fix for 1 vulnerabilities qmutz/deck#11

Open

[Snyk] Fix for 1 vulnerabilities GOMYWAY-NETWORKS-LLC/deck#7

Open

This was referenced Dec 27, 2023

[Snyk] Fix for 1 vulnerabilities GOMYWAY-NETWORKS-LLC/deck#12

Open

[Snyk] Fix for 1 vulnerabilities qmutz/deck#16

Open

This was referenced Jan 5, 2024

[Snyk] Fix for 1 vulnerabilities qmutz/deck#18

Open

[Snyk] Fix for 1 vulnerabilities GOMYWAY-NETWORKS-LLC/deck#14

Open

	<button v-tooltip="t('deck', 'Edit')" class="icon-rename" @click="clickEdit(label)" />
	<button v-tooltip="t('deck', 'Edit')" class="icon-rename" @click="clickEdit(label)" />

Label editing in board sidebar #935

Label editing in board sidebar #935

Uh oh!

Conversation

jakobroehrl commented Mar 12, 2019 • edited by juliusknorr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

Checklist

Uh oh!

Uh oh!

juliusknorr commented Apr 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

juliusknorr Apr 17, 2019

Choose a reason for hiding this comment

Uh oh!

juliusknorr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

juliusknorr commented Apr 17, 2019

Uh oh!

Uh oh!

juliusknorr Apr 25, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juliusknorr commented Apr 25, 2019

Uh oh!

juliusknorr commented Apr 26, 2019

Uh oh!

juliusknorr commented Apr 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jakobroehrl commented Mar 12, 2019 •

edited by juliusknorr

Loading

juliusknorr commented Apr 11, 2019 •

edited

Loading