Adds apps and external sites to menu #195
Conversation
Signed-off-by: Camila San <[email protected]>
Signed-off-by: Camila San <[email protected]>
Signed-off-by: Camila San <[email protected]>
Uses option to toggle display of external sites list in the main menu. Signed-off-by: Camila San <[email protected]>
Signed-off-by: Camila San <[email protected]>
Signed-off-by: Camila San <[email protected]>
Signed-off-by: Camila San <[email protected]>
Signed-off-by: Camila San <[email protected]>
Signed-off-by: Camila San <[email protected]>
Signed-off-by: Camila San <[email protected]>
Signed-off-by: Camila San <[email protected]>
…cked in the settings. Signed-off-by: Camila San <[email protected]>
Signed-off-by: Camila San <[email protected]>
Signed-off-by: Camila San <[email protected]>
Signed-off-by: Camila San <[email protected]>
…ob in OwncloudGui. Signed-off-by: Camila San <[email protected]>
Signed-off-by: Camila San <[email protected]>
…on/apps endpoint. Signed-off-by: Camila San <[email protected]>
…ync. Signed-off-by: Camila San <[email protected]>
camilasan
force-pushed
the
apps-external-sites-menu
branch
6 times, most recently
from
3933795 to
1200bc9
Compare
…make sure apps is added to the right position. Signed-off-by: Camila San <[email protected]>
camilasan
force-pushed
the
apps-external-sites-menu
branch
from
1200bc9 to
99d8d05
Compare
camilasan
changed the title
src/gui/owncloudgui.cpp
Outdated
| foreach (const QJsonValue &value, navLinks) { | ||
| auto navLink = value.toObject(); | ||
| QAction *action = new QAction(navLink.value("name").toString(), this); | ||
| QUrl href(account->url().host() + navLink.value("href").toString()); |
There was a problem hiding this comment.
You can just add absolute=true as a get parameter to the OCS request, so the href value already contains the full URL.
There was a problem hiding this comment.
Besides that opening fails for me with the following error, when clicking the menu item:
gio: file:///home/jus/repos/nextcloud/build-client-Desktop-Debug/bin/localhost/index.php/apps/contacts: Could not fetch information from »/home/jus/repos/nextcloud/build-client-Desktop-Debug/bin/localhost/index.php/apps/contacts«: File for directory not found
There was a problem hiding this comment.
Done. Please, try it again.
|
Nice work @camilasan One minor thing is, that the menu entry shows up after the menu is shown (with the delay of the request). I think we should have it loaded by default and just update it if the request returns anything new. |
|
@juliushaertl in the PR #197 I am using If-None-Match ETag to check for new notifications. Could we use the same in ocs/v2.php/core/navigation/apps? |
Signed-off-by: Camila San <[email protected]>
|
@camilasan Here we go: nextcloud/server#8652 |
|
Can we merge this @juliushaertl ? I will work with If-None-Match ETag in another PR. |
This implements the request by @karlitschek "It would be great for Nextcloud apps to have the opportunity to create an entry in the primary Desktop Client Menu. So for example the Calendar app could request to have a 'Calendar' entry in the Desktop Client menu. On click it should open the default browser with an url. In this case the Nextcloud Calendar. This would help a lot to promote the Server side apps like Calendar, Spreed, Notes, ..."
The apps are in a section above the section of »Pause all folders« and »Log out«.
One user:
Multiple users:
One extra: I removed two menu actions in the code that were never being added to any menu.