Skip to content
Draft
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
4f4fd60
gitignore: Ignore clangd-generated directory .cache/
taminob Oct 31, 2023
ed5fdd8
cmake: Export compile_commands.json by default
taminob Oct 31, 2023
5812d5c
libsync: Remove auto-exclude for symlinks
taminob Oct 31, 2023
40145c9
libsync/common: Store actual type for items
taminob Oct 31, 2023
0370594
libsync: Add header field OC-File-Type for symlink synchronization
taminob Oct 31, 2023
d66c704
libsync: Add SymLinkUploadDevice for reading symlinks
taminob Nov 2, 2023
c34659b
libsync: Use SymLinkUploadDevice for single symlink uploads
taminob Nov 2, 2023
7b92b2e
libsync: Add support for symlinks in bulk uploads
taminob Nov 4, 2023
390e8f6
libsync: Fix _read for SymLinkUploadDevice
taminob Nov 5, 2023
af53d58
libsync: Allow download of symlinks
taminob Nov 5, 2023
aee6601
libsync: Fix Content-Length for symlinks in bulk upload
taminob Nov 12, 2023
a551b24
common: Do not dereference symlink when checking existence
taminob Nov 15, 2023
7876341
libsync: Fix checksum and size for symlinks in bulk upload
taminob Nov 15, 2023
c5b8235
libsync: Add symlink type to DiscoveryPhase
taminob Nov 23, 2023
10d0fcc
common: Allow checksum calculation on QIODevice again
taminob Nov 27, 2023
e7c357c
libsync: Add readlink to FileSystem and fix getSize for symlinks
taminob Nov 27, 2023
719e014
BulkPropagatorJob: Remove symlink size special case
taminob Nov 28, 2023
8f05e93
FileSystem: Fix fileEquals for symlinks
taminob Nov 28, 2023
f5d6110
gui/config: Add symlink synchronization as sync option
taminob Nov 30, 2023
4866922
Revert "common: Allow checksum calculation on QIODevice again"
taminob Dec 2, 2023
6df006d
filesystem: Move readlink from libsync/filesystem.h to common/filesys…
taminob Dec 4, 2023
97f015c
ChecksumCalculator: Calculate symlink checksum on symlink target
taminob Dec 4, 2023
845e108
discoveryphase: Fix local entry size for symlinks
taminob Dec 4, 2023
7a6df0e
ChecksumCalculator: Fix creation of QBuffer
taminob Dec 4, 2023
81dbb9d
FileSystem: Make readlink C++20 compliant
taminob Dec 4, 2023
91a5e54
csync/FileSystem: Adjust c_utimes to not follow symlinks
taminob Dec 6, 2023
d5b61b2
discovery: Check if symlink for server entries
taminob Dec 6, 2023
d36b7b9
OwncloudPropagator: Fix condition for deletion of previous remote item
taminob Dec 6, 2023
5bcf57a
OwncloudPropagator: Only download symlink if enabled by option
taminob Dec 6, 2023
fa16c33
PropagateDownloadFile: Allow symlink to be larger than 8kB
taminob Dec 6, 2023
f779b3e
PropagateDownloadFile/FileSystem: Preserve permissions for symlinks
taminob Dec 8, 2023
5265ed4
PropagateDownloadFile/FileSystem: Improve previous commit (by mainly …
taminob Dec 8, 2023
c61a574
ConflictDialog: Fix size and mtime for symlinks in conflict resolution
taminob Dec 10, 2023
38f5dac
ActivityListModel: Modify ignore text to not include symlinks
taminob Dec 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
common: Do not dereference symlink when checking existence
Signed-off-by: Tamino Bauknecht <[email protected]>
  • Loading branch information
taminob committed Dec 10, 2023
commit a551b2453dc5f9cf9664b7b0705d646061d5c34e
4 changes: 2 additions & 2 deletions src/common/filesystembase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -312,13 +312,13 @@ bool FileSystem::fileExists(const QString &filename, const QFileInfo &fileInfo)
return fileExistsWin(filename);
}
#endif
bool re = fileInfo.exists();
bool re = fileInfo.exists() || fileInfo.isSymLink();
// if the filename is different from the filename in fileInfo, the fileInfo is
// not valid. There needs to be one initialised here. Otherwise the incoming
// fileInfo is re-used.
if (fileInfo.filePath() != filename) {
QFileInfo myFI(filename);
re = myFI.exists();
re = myFI.exists() || myFI.isSymLink();
}
return re;
}
Expand Down