Skip to content

add ci test image for PHP 7.2 #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 1 commit into from
Apr 20, 2020
Merged

add ci test image for PHP 7.2 #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add ci test image for PHP 7.2 
Signed-off-by: Arthur Schiwon <[email protected]>
  • Loading branch information
@blizzz
blizzz committed Mar 18, 2020
commit 812fe4090a738d820b1241044deffd1f0ab0b02a
9 changes: 9 additions & 0 deletions integration-php7.2/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
FROM nextcloudci/php7.2:php7.2-13
Copy link
Contributor

@kesselb kesselb Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you used a fixed version? I was wondering about that when adding xdebug again to some images. It's a nightmare ;) Given that images are only built on tagging using latest should be fine.

Copy link
Member

@skjnldsv skjnldsv Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we didn't use latest tag. I added it in some builds last month, but lots are missing

Copy link
Contributor

@kesselb kesselb Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I thought the latest tag is automatically done by docker ;) The good thing is you already added it to https://hub.docker.com/r/nextcloudci/php7.2/tags so we can use it 🎉


RUN composer global require hirak/prestissimo

RUN mkdir /tmp/server && \
cd /tmp/server && git clone --recursive https://github.com/nextcloud/server.git && \
cd /tmp/server/server/build/integration && composer install && \
cd /tmp/server/server/tests/acceptance && composer install && \
rm -rf /tmp/server