/.well-known/webfinger nginx rule for Social app #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Sulzer <[email protected]>
Member
Author
|
/backport to stable15 |
skjnldsv
approved these changes
Dec 8, 2018
|
backport to stable15 in #1025 |
Member
|
Nice nice! Would any harm be done by just having it in there by default and saying "comment / remove the line if you don’t plan on using it"? |
Member
Author
|
I'm not sure if the redirect would just lead to a 404 if there is nothing behind it or if it could become a potential security issue? @juliushaertl or @daita Do you know what happens if this redirect exists even tough Social is not installed? (How do we do it for the .htaccess? Is the line only added on the install of social or is it added by default for NC15 upwards?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @nextcloud/social
Signed-off-by: Jonas Sulzer [email protected]