reverse_proxy_configuration.rst: IPv6 CIDR is supported #11231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ince v25.0.0-beta1 Signed-off-by: Jivan Pal <[email protected]>
tflidd
approved these changes
Oct 27, 2023
joshtrichards
approved these changes
Oct 27, 2023
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
👍 And looks like the config sample got taken care of in nextcloud/server#35956.
Contributor
Author
|
@joshtrichards Would we like to add the example addresses to match nextcloud/server#35956 ? |
Contributor
|
If you want to add an example, I'd rather use a subnet size of at least /64. But if you add it, wouldn't you need to put ipv4 examples as well? |
kesselb
approved these changes
Nov 21, 2023
Member
Member
|
/backport to stable27 |
Member
|
/backport to stable26 |
This was referenced Nov 27, 2023
Member
|
Done, @kyrofa. Thanks for the reminder! |
Member
|
My pleasure, thank YOU! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed that IPv6 CIDR notation works on server v27.0.0. Apparently, this has been supported since v25.0.0-beta1; see nextcloud/server#32615