Document shared items feature for contacts #11270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
GretaD
changed the title
ChristophWurst
requested changes
Nov 7, 2023
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Add a screenshot of the rendered page
user_manual/groupware/contacts.rst
Outdated
|
|
||
| Shared items | ||
| ~~~~~~~~~~~~ | ||
| The contact app supports shared item starting from version 5.5.0. Media, calendar events, talk chat room between you and another contact or shared deck cards, will be shown on the contact details. You need to have the app activated in order to see the shared items of that app. Right now, we only support the shared items between 2 contacts. |
Member
There was a problem hiding this comment.
- The user can't enable an app. Drop the note about enabled app.
- Use https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-versionadded to render when the feature was added.
- Add note that this only works for contacts in the system address book
Contributor
Author
There was a problem hiding this comment.
done, i rephrased it a bit as it was very plain
user_manual/groupware/contacts.rst
Outdated
| Shared items | ||
| ~~~~~~~~~~~~ | ||
| .. versionadded:: 5.5 | ||
| .. figure:: ../images/shared-items.png |
Member
There was a problem hiding this comment.
I meant a screenshot for the PR description but this is nice too :)
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
👍 Add a screenshot of the modified docs page to the PR then we can merge
Contributor
Author
the way how you add images on github has changed. I couldnt find how to do it and assumed it is a temporary issue. Updated |
Member
|
This is only to be merged when the feature PR is in, in case there is a delay |
hamza221
approved these changes
Nov 9, 2023
Signed-off-by: greta <[email protected]>
GretaD
force-pushed
the
add/shared-items
branch
from
b833a87 to
1c74c4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots