Skip to content

fix(admin): Remove "latest" archive reference during upgrades #11838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshtrichards merged 2 commits into from
May 23, 2024
Merged

fix(admin): Remove "latest" archive reference during upgrades #11838

joshtrichards merged 2 commits into from
May 23, 2024

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented May 17, 2024

☑️ Resolves

  • adjusts step 2 to avoid breaking things
    • specifically: installing the latest tarball/zip file isn't always the correct choice; e.g. 27 -> 29 will break their installation
  • also adds reminder about checking new system requirements and the standard upgrade requirements

🖼️ Screenshots

image

@joshtrichards
Copy link
Member Author

joshtrichards commented May 17, 2024

/backport to stable29

@joshtrichards
Copy link
Member Author

joshtrichards commented May 17, 2024

/backport to stable28

@joshtrichards
Copy link
Member Author

joshtrichards commented May 17, 2024

/backport to stable27

@joshtrichards joshtrichards changed the title fix(admin): Remove "latest" archive reference to avoid accidents fix(admin): Remove "latest" archive reference during upgrades May 22, 2024
tflidd
tflidd approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@tflidd tflidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the improvements.
Only thing, I don't know if it is perhaps to obvious, that the www-data user is mainly for debian-based distributions. Most beginners use that, and other systems with different users might have enough experience to be aware of this. But could be a further improvement (other parts of the documentation are affected by this as well).

@joshtrichards
Copy link
Member Author

joshtrichards commented May 23, 2024 •
edited
Loading

Only thing, I don't know if it is perhaps to obvious, that the www-data user is mainly for debian-based distributions.

Yeah I agree. It gets confusing. That's going to take further passes later on (outside of this PR). The docs are littered with stuff like that. The big picture overview on tackling that is #11447. In the mean time... 🤷‍♂️

@joshtrichards joshtrichards enabled auto-merge May 23, 2024 13:11
@joshtrichards joshtrichards merged commit 5f0a7ba into master May 23, 2024
@joshtrichards joshtrichards deleted the jtr/admin-manual-upgrade-not-latest branch May 23, 2024 13:39
This was referenced May 23, 2024
Merged
Merged
Merged
@joshtrichards
Copy link
Member Author

joshtrichards commented May 23, 2024

/backport to stable26

@backportbot backportbot bot mentioned this pull request May 23, 2024
Merged
@github-actions

This comment was marked as resolved.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tflidd tflidd tflidd approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

3. to review bug feedback-requested manual: admin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshtrichards @tflidd