Skip to content

Document changes in IGroupManager and ICreateGroupBackend #12042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 2 commits into from
Jul 19, 2024
Merged

Document changes in IGroupManager and ICreateGroupBackend #12042

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e093293
feat(developer): document changes in IGroupManager and ICreateGroupBa…
Altahrim Jul 19, 2024
30a6a36
Update developer_manual/app_publishing_maintenance/app_upgrade_guide/…
Altahrim Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(developer): document changes in IGroupManager and ICreateGroupBa… 
…ckend

Signed-off-by: Benjamin Gaussorgues <[email protected]>
  • Loading branch information
@Altahrim
Altahrim committed Jul 19, 2024
commit e093293738ff231b93d29aabacad23349a10a09c
2 changes: 2 additions & 0 deletions developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ Changed APIs
- Calling ``OCP\Notification\INotification::setLink()`` with a relative URL is deprecated and will throw ``OCP\Notification\InvalidValueException`` in a future version.
- Calling ``OCP\Notification\INotification::setIcon()`` with a relative URL is deprecated and will throw ``OCP\Notification\InvalidValueException`` in a future version.
- ``OCP\Notification\INotifier::prepare()`` should no longer throw ``\InvalidArgumentException``. ``OCP\Notification\UnknownNotificationException`` should be thrown when the notifier does not want to handle the notification. ``\InvalidArgumentException`` are logged as debug for now and will be logged as error in the future to help developers find issues from code that unintentionally threw ``\InvalidArgumentException``
- ``OCP\IGroupManager`` should be used instead of checking is current user is part of admin group manually.

Deprecated APIs
^^^^^^^^^^^^^^^
Expand All @@ -137,6 +138,7 @@ Deprecated APIs
- Using the ``@NoAdminRequired`` annotation is deprecated and the ``#[OCP\AppFramework\Http\Attribute\NoAdminRequired]`` attribute should be used instead.
- Using the ``@StrictCookieRequired`` annotation is deprecated and the ``#[OCP\AppFramework\Http\Attribute\StrictCookiesRequired]`` attribute should be used instead.
- Using the ``@NoCSRFRequired`` annotation is deprecated and the ``#[OCP\AppFramework\Http\Attribute\NoCSRFRequired]`` attribute should be used instead.
- Using the ``OCP\Group\Backend\ICreateGroupBackend`` interface is now deprecated and the ``OCP\Group\Backend\ICreateNamedGroupBackend`` interface should be used instead.

Removed APIs
^^^^^^^^^^^^
Expand Down