Skip to content

Conversation

@jameskimmel
Copy link
Contributor

☑️ Resolves

  • Brute force is enabled by default, but not the app.

Signed-off-by: jameskimmel <[email protected]>
@jameskimmel jameskimmel marked this pull request as ready for review July 29, 2024 20:35
Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!


Brute force protection is enabled by default on Nextcloud. Its behavior can be adjusted through the
``bruteforcesettings`` app (shipped with Server and enabled by default), several ``occ`` commands, and several
``bruteforcesettings`` app, several ``occ`` commands, and several
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
``bruteforcesettings`` app, several ``occ`` commands, and several
``bruteforcesettings`` app (shipped with Server, but disabled by default), several ``occ`` commands, and several

~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This app, which shipped and enabled by default, makes it possible (via the Web UI) to view the status of a
This app makes it possible (via the Web UI) to view the status of a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This app makes it possible (via the Web UI) to view the status of a
This app (once enabled) makes it possible (via the Web UI) to view the status of a

@joshtrichards
Copy link
Member

Though maybe we should have this enabled by default anyhow. :-) Either way, docs should be updated to reflect current behavior. Thanks for sending this in!

@jameskimmel
Copy link
Contributor Author

jameskimmel commented Jul 30, 2024

You are very welcome, and thank you for taking a look. I enabled it today for testing but disabled it again since I don't see any use case for me. Is there no setting besides the whitelist?

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@nickvergessen
Copy link
Member

Since the app is now shipped and enabled by default in 30+ close this and send it against 29?

@jameskimmel
Copy link
Contributor Author

jameskimmel commented Aug 19, 2024

Since the app is now shipped and enabled by default in 30+ close this and send it against 29?

Sorry, I don't know how stuff like this works here. Should I close the issue, since it is resolved in 30?
What do you mean be "send it against 29"?

@nickvergessen
Copy link
Member

/backport! to stable29

@backportbot
Copy link

backportbot bot commented Aug 19, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/12066/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7c389f1a

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/12066/stable29

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nickvergessen
Copy link
Member

No problem, I can do that for you

@nickvergessen
Copy link
Member

#12118

@jameskimmel jameskimmel deleted the patch-1 branch August 21, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants