Skip to content

Conversation

@alperozturk96
Copy link
Contributor

@alperozturk96 alperozturk96 commented Jul 30, 2024

☑️ Resolves

This pull request includes documentation for handling deep links in Android applications, specifically addressing the requirements and configurations for Android 12 and above.

Demo

t.mp4

🖼️ Screenshots

Screenshot 2025-06-05 at 13 02 08

@alperozturk96 alperozturk96 changed the title Add documentation for Android Deep Link Handling Add Documentation for Android Deep Link Handling Jul 30, 2024
@alperozturk96 alperozturk96 force-pushed the add-deep-link-handling-android branch from f192dba to 2e330ae Compare July 30, 2024 10:13
@alperozturk96 alperozturk96 force-pushed the add-deep-link-handling-android branch from 046ea76 to 15186a8 Compare July 30, 2024 10:21
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This page is not included anywhere
  • Heading lines do not match the heading text length
  • Heading structure makes no sense. There should be a page title, then sections, etc. Right now there are four sections with =

Comment on lines 40 to 41
Replace APP_SHA256_FINGERPRINT with the SHA-256 fingerprint of your app’s
signing certificate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is only applicable to branded apps, right?

This either needs a big caveat at the top of the chapter or maybe it shouldn't be included here since it's not applicable to community users... so maybe it only belongs in the customer docs in https://portal.nextcloud.com somewhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alperozturk96 this also works for our official app, right?
So maybe add the sha256 of our app here.
And as Josh suggested, add a portal entry how this needs to be changed for branded apps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasKaminsky How can I add portal entry?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Portal PR

@joshtrichards
Copy link
Member

This page is not included anywhere

The globbing recently added in #11691 should pick it up. :-)

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good structure-wise. Can't say much about the content :)

@ChristophWurst ChristophWurst dismissed their stale review July 30, 2024 17:19

Addressed

@alperozturk96 alperozturk96 force-pushed the add-deep-link-handling-android branch from f4a1b27 to 21ebe10 Compare August 1, 2024 07:17
@joshtrichards
Copy link
Member

Is this intended as an alternative approach to nextcloud/server#44665?

@alperozturk96
Copy link
Contributor Author

alperozturk96 commented Aug 2, 2024

Is this intended as an alternative approach to nextcloud/server#44665?

No, that PR is only functional for us. If a user wants to use it with a different server name, it will not work on Android 12 or above.

For more details

@ChristophWurst

This comment was marked as resolved.

@alperozturk96

This comment was marked as resolved.

@alperozturk96 alperozturk96 marked this pull request as draft June 4, 2025 12:24
@alperozturk96
Copy link
Contributor Author

Demo

t.mp4

@alperozturk96 alperozturk96 force-pushed the add-deep-link-handling-android branch from 8df00f2 to e68d2c5 Compare June 5, 2025 05:02
@alperozturk96 alperozturk96 marked this pull request as ready for review June 5, 2025 05:02
@alperozturk96 alperozturk96 marked this pull request as draft June 5, 2025 05:13
@alperozturk96

This comment was marked as resolved.

alperozturk96 and others added 13 commits June 13, 2025 16:01
Signed-off-by: alperozturk <[email protected]>
Co-authored-by: Josh <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Co-authored-by: Josh <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Co-authored-by: Josh <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Co-authored-by: Josh <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Co-authored-by: Josh <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the add-deep-link-handling-android branch from c97e675 to 5f05fcb Compare June 13, 2025 14:01
@alperozturk96 alperozturk96 marked this pull request as ready for review June 13, 2025 14:06
@tobiasKaminsky tobiasKaminsky merged commit 060f51f into master Jun 20, 2025
15 checks passed
@tobiasKaminsky tobiasKaminsky deleted the add-deep-link-handling-android branch June 20, 2025 08:26
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@Routhinator
Copy link

Routhinator commented Dec 10, 2025

This doc includes the official SHA256 for the Nextcloud client in the assetlinks.json there - but did you actually intend to have "package_name": "com.cloud.example.nextcloud"?

Isn't the package name com.nextcloud.client? Or are we supposed to customize this to our domains? This seems unclear in the way this doc is currently presented.

EDIT: Managed to confirm that yes, this should have been com.nextcloud.client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants