Update nginx-root.conf.sample #12100
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Hi @susnux can you please have a look? every new upgrade I have to manually compare the nginx file revisions to make sure nothing is broken. This would make it way easier. Thanks! |
Add version so its easy to check when updates are needed Signed-off-by: michnovka <[email protected]>
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/documentation/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
It was removed from the config in #9188, but forgotten for the static assets block. In addition, the date added with #12100 was is added to the subdir config as well, for consistency. Signed-off-by: MichaIng <[email protected]>
2 participants
Add version so its easy to check when updates are needed
Right now from time to time when sth breaks I have to open nextcloud nginx docs page and compare line by line with my local webserver setup to see where new changes were introduced. This will simplify it greatly, provided that people who change the documentation update the version date when relevant changes are made to the conf file.