feat: add schemas for new calendar object webhook events #12801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edward-ly
force-pushed
the
feat/webhook-calendar-obj-event
branch
2 times, most recently
from
105aee0 to
65b415a
Compare
ChristophWurst
approved these changes
Mar 17, 2025
edward-ly
changed the title
Signed-off-by: Edward Ly <[email protected]>
edward-ly
force-pushed
the
feat/webhook-calendar-obj-event
branch
from
65b415a to
fc04d64
Compare
st3iny
reviewed
Mar 17, 2025
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
I just realized that we are leaking Sabre classes in this public (OCP) API, for example, in the supported component set member. I know it's a bit late now but we should keep that in mind for the future.
Contributor
Author
|
Do the Sabre classes contain important information that may be useful for webhooks? If not, maybe it's OK to filter out some unneeded properties. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots