Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Jun 16, 2025

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @miaulalala to return and clarify nextcloud/server#51113 (comment) ?

@st3iny
Copy link
Member Author

st3iny commented Jun 16, 2025

Sounds good. Given that this interface is not a implementable but only a consumable it should be fine to merge the new methods into the old interface.

But let's wait for @miaulalala.

@rakekniven rakekniven force-pushed the feat/developer/ocm-capability-aware-provider branch from fd9c82c to 2f8e7e2 Compare June 16, 2025 21:02
@rakekniven rakekniven self-requested a review June 16, 2025 21:05
@miaulalala
Copy link
Contributor

Let's wait for @miaulalala to return and clarify nextcloud/server#51113 (comment) ?

Yeah, the intention was to avoid exactly that situation - where apps have to change their implementation 🙈 so adding both interfaces to DI is what I had in mind. Ah well. Best laid plans and all that. Doc looks good, thanks @st3iny !

@st3iny st3iny requested a review from nickvergessen June 23, 2025 13:55
@nickvergessen nickvergessen merged commit 9af71c5 into master Jun 23, 2025
13 checks passed
@nickvergessen nickvergessen deleted the feat/developer/ocm-capability-aware-provider branch June 23, 2025 15:24
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants