Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Aug 6, 2025

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on listing this in the upgrade guide so app devs can check their notifiers and modify them if needed

But this should also have a dedicated page, regardless of the 32 changes, with an example to demonstrate the purpose of the preload

@nickvergessen
Copy link
Member

nickvergessen commented Aug 6, 2025

That would then be https://github.com/nextcloud/notifications/blob/master/docs/notification-workflow.md

Or we move all this over at some point.

Since I hold a lightning Talk about this, I can take care of it when preparing that.

@ChristophWurst
Copy link
Member

Personally I would prefer to have this in the dev manual where we also cover the rest of OCP, so 👍 on moving it over :)

@st3iny st3iny merged commit 609f914 into master Aug 6, 2025
13 checks passed
@st3iny st3iny deleted the feat/developer/i-preloadable-notifier branch August 6, 2025 08:17
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants