Skip to content

Do not (yet) recommended PHP 7.4 #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
J0WI wants to merge 1 commit into from
Closed

Do not (yet) recommended PHP 7.4 #2117

J0WI wants to merge 1 commit into from

Conversation

@J0WI
Copy link
Contributor

@J0WI J0WI commented May 30, 2020

No description provided.

@J0WI J0WI mentioned this pull request May 30, 2020
Closed
@J0WI J0WI requested review from ChristophWurst and kesselb June 4, 2020 19:41
@kesselb kesselb requested review from MorrisJobke and rullzer June 4, 2020 19:48
@rullzer
Copy link
Member

rullzer commented Jun 5, 2020

Why not?

@ChristophWurst
Copy link
Member

ChristophWurst commented Jun 5, 2020

#2037 (comment) but I do not think this is necessarily true anymore.

@kesselb
Copy link
Contributor

kesselb commented Jun 5, 2020

There are some warnings with 7.4.

@rullzer
Copy link
Member

rullzer commented Jun 5, 2020

Warnings are not really a reason not to recommend something.
We should just fix them. I am running nextcloud for some months now with php7.4 and it is working just fine.

@kesselb
Copy link
Contributor

kesselb commented Jun 5, 2020

I am running nextcloud for some months now with php7.4 and it is working just fine.

You are a developer. That's a different story ;) Admin checks the logs, see warnings, searches for a reason. It's often hard to judge for them if the log message is critical or not.

nextcloud/groupfolders#907
nextcloud/server#18996

@ChristophWurst
Copy link
Member

ChristophWurst commented Jun 5, 2020

But you fixed those, right?

@kesselb
Copy link
Contributor

kesselb commented Jun 5, 2020

But you fixed those, right?

The patch with SCSS is not backported yet. As the original patch is for scssphp 1.03 and we still have scssphp 0.7.x with stable18 not sure if it will.

@rullzer
Copy link
Member

rullzer commented Jun 5, 2020

ok then lets do it for stable18.

@J0WI
Copy link
Contributor Author

J0WI commented Feb 25, 2021

18 is EOL

@J0WI J0WI closed this Feb 25, 2021
@J0WI J0WI deleted the 18-7.4-not-recommended branch February 25, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

3. to review manual: admin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@J0WI @rullzer @ChristophWurst @kesselb