Skip to content

Document client login flow login name mismatch #7036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 1 commit into from
Mar 22, 2022
Merged

Document client login flow login name mismatch #7036

blizzz merged 1 commit into from
Mar 22, 2022

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Aug 13, 2021

@ChristophWurst ChristophWurst added this to the Nextcloud 23 milestone Aug 13, 2021
@ChristophWurst ChristophWurst requested a review from FlexW August 13, 2021 08:40
@ChristophWurst ChristophWurst self-assigned this Aug 13, 2021
@ChristophWurst
Copy link
Member Author

ChristophWurst commented Aug 13, 2021

/backport to stable22

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Aug 13, 2021

/backport to stable21

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Aug 13, 2021

/backport to stable20

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Oct 20, 2021

@FlexW can you give this a review please? :)

@FlexW
Copy link

FlexW commented Oct 21, 2021

But isn't that different from what here is written https://docs.nextcloud.com/server/latest/developer_manual/client_apis/LoginFlow/index.html#obtaining-the-login-credentials because when I read this I think I can use user name, email address or login name for login, but after the login, I should always use the username?

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Oct 25, 2021

I already forgot the details. Are you sure only the username works later on? I thought as long as you use the two consistently it's fine.

@blizzz blizzz modified the milestones: Nextcloud 23, Nextcloud 23.0.1 Nov 30, 2021
@blizzz blizzz modified the milestones: Nextcloud 23.0.3, Nextcloud 24 Mar 22, 2022
@blizzz blizzz merged commit 13a9efc into master Mar 22, 2022
@blizzz blizzz deleted the enh/dev-client-flow-login-name-mismatch branch March 22, 2022 09:01
This was referenced Mar 22, 2022
Merged
Merged
Merged
@joshtrichards joshtrichards mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@FlexW FlexW Awaiting requested review from FlexW

Assignees

@ChristophWurst ChristophWurst

Labels

3. to review

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst @FlexW @blizzz