Add hint about "fileinfo" module being required for theming #9118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Theming app requires the "mime_content_type" function, which is part of the "fileinfo" module, to identify the mime type of the custom images. Moreover, if the "imagick" module is installed and it has support for SVG files a rasterized counterpart will be generated for the SVG app icons. In this case "mime_content_type" is used to identify the mime type of the original icon. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
kesselb
deleted the
add-hint-about-module-fileinfo-being-required-for-theming
branch
This was referenced Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Theming app requires the
mime_content_typefunction, which is part of thefileinfomodule, to identify the mime type of the custom images. Currently ifmime_content_typeis not available the Theming UI does not show any error, but that is fixed in nextcloud/server#33332Moreover, if the
imagickmodule is installed and it has support for SVG files a rasterized counterpart will be generated for the SVG app icons. In this casemime_content_typeis used to identify the mime type of the original icon. If testing this by adding or removing the extension once Nextcloud has been already set up beware of the cached value.I tried to replace the usages of
mime_content_typein the Theming app with the IMimeTypeDetector implementation, which tries in more ways than justmime_content_type. Unfortunately it does not work, as the secure mime type forSVG+XMLfiles istext/plainrather thanimage/svg+xml, and thus are not properly handled by the Theming app.