Skip to content

Document export size estimation API #9123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
come-nc merged 1 commit into from
Jul 28, 2022
Merged

Document export size estimation API #9123

come-nc merged 1 commit into from
Jul 28, 2022

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Jul 26, 2022

Close #9113

@Pytal Pytal added this to the Nextcloud 25 milestone Jul 26, 2022
@Pytal Pytal self-assigned this Jul 26, 2022
@nickvergessen nickvergessen removed their request for review July 27, 2022 07:15
@come-nc come-nc merged commit b334d83 into master Jul 28, 2022
@come-nc come-nc deleted the export-size-estimation-api branch July 28, 2022 07:10
@Valdnet
Copy link
Contributor

Valdnet commented Jul 28, 2022

@Pytal The unit should be in KB.

@Pytal
Copy link
Member Author

Pytal commented Jul 28, 2022

As KiB unambiguously means 1024 bytes whereas KB could mean 1000 or 1024 bytes it was chosen in this case

@come-nc can you confirm?

@Valdnet
Copy link
Contributor

Valdnet commented Jul 29, 2022

If we are talking about a binary unit, it is well marked 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nc come-nc come-nc approved these changes

@artonge artonge Awaiting requested review from artonge

@Valdnet Valdnet Awaiting requested review from Valdnet

Assignees

@Pytal Pytal

Labels

4. to release manual: developer

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

Document export size estimation API

4 participants

@Pytal @Valdnet @come-nc