Skip to content

Conversation

@nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added 2. developing Work in progress technical debt Technical issue labels Apr 22, 2021
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #232 (edec90f) into master (27f51b8) will increase coverage by 0.73%.
The diff coverage is 100.00%.

❗ Current head edec90f differs from pull request most recent head ebfe62b. Consider uploading reports for the commit ebfe62b to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #232      +/-   ##
============================================
+ Coverage     83.78%   84.51%   +0.73%     
+ Complexity      328      321       -7     
============================================
  Files            30       30              
  Lines           925      917       -8     
============================================
  Hits            775      775              
+ Misses          150      142       -8     
Flag Coverage Δ Complexity Δ
php 84.51% <100.00%> (+0.73%) 321.00 <11.00> (-7.00) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/Connector/Sabre/RedirectRequestPlugin.php 57.30% <100.00%> (ø) 34.00 <0.00> (ø)
lib/Db/LockMapper.php 100.00% <100.00%> (ø) 5.00 <3.00> (-2.00)
lib/MetaDataStorage.php 91.66% <100.00%> (ø) 39.00 <0.00> (-1.00)
lib/RollbackService.php 96.87% <100.00%> (ø) 9.00 <8.00> (-1.00)
lib/AppInfo/Application.php 0.00% <0.00%> (ø) 6.00% <0.00%> (ø%)
lib/Migration/Version1005Date20200312102456.php 0.00% <0.00%> (ø) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f51b8...ebfe62b. Read the comment docs.

Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Copy link
Member Author

/backport to stable21

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Apr 22, 2021
@ChristophWurst ChristophWurst merged commit be5e52b into master Apr 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the techdebt/noid/check-php-8.0 branch April 22, 2021 09:19
@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress technical debt Technical issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants