Skip to content

Conversation

@nickvergessen
Copy link
Member

No description provided.

@juliusknorr
Copy link
Member

@nickvergessen Any objections on getting this in already? Would help to move on with the new cases I've written in #321 to run them individually against the other PRs I've pending.

@nickvergessen
Copy link
Member Author

Will do fixup and cs fixing then we can

@nickvergessen nickvergessen marked this pull request as ready for review March 24, 2023 13:58
@nickvergessen nickvergessen self-assigned this Mar 24, 2023
@juliusknorr
Copy link
Member

DCO failing from 5c50bfd

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides the failing DCO check

@nickvergessen
Copy link
Member Author

Looks good besides the failing DCO check

Right, removed as per commit msg

@juliusknorr juliusknorr merged commit 3bd46bc into master Mar 24, 2023
@juliusknorr juliusknorr deleted the integration-tests branch March 24, 2023 14:36
@juliusknorr
Copy link
Member

/backport to stable26

@juliusknorr
Copy link
Member

/backport to stable25

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants