Add limit message on public page #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
force-pushed
the
feat/public
branch
from
a0b9327 to
4e1befd
Compare
Pytal
reviewed
Sep 15, 2021
| import { translatePlural as n } from '@nextcloud/l10n' | ||
|
|
||
| const { limit, downloads } = loadState(appName, 'download_limit', { limit: -1, downloads: 0 }) | ||
| console.debug('[DEBUG]', appName, { limit, downloads }) |
Member
There was a problem hiding this comment.
Should we use @nextcloud/logger here instead as a followup?
| const span = document.createElement('span') | ||
|
|
||
| span.style = 'color: var(--color-primary-text); padding: 0 10px;' | ||
| span.innerText = n('files_downloadlimit', '1 more download allowed', '{count} more downloads allowed', count, { count }) |
Member
There was a problem hiding this comment.
Definitely workable, I would suggest 1 remaining download allowed for singular and {count} remaining downloads allowed for the plural version :)
This was referenced Sep 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6