Skip to content

Do not show if not a file or if share doesn't exists #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Apr 8, 2022
Merged

Do not show if not a file or if share doesn't exists #75

skjnldsv merged 1 commit into from
Apr 8, 2022

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 8, 2022 •
edited
Loading

@skjnldsv skjnldsv self-assigned this Apr 8, 2022
@skjnldsv skjnldsv requested review from a team, PVince81, szaimen and vanpertsch and removed request for a team April 8, 2022 12:51
@skjnldsv skjnldsv added the bug Something isn't working label Apr 8, 2022
@skjnldsv skjnldsv changed the title Do not show if not a file Do not show if not a file or if share doesn't exists Apr 8, 2022
@skjnldsv skjnldsv requested review from CarlSchwan and come-nc April 8, 2022 12:53
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Apr 8, 2022
szaimen
szaimen approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and works :)

@skjnldsv skjnldsv merged commit c3494bc into master Apr 8, 2022
@skjnldsv skjnldsv deleted the fix/folder branch April 8, 2022 16:06
@skjnldsv skjnldsv mentioned this pull request Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@vanpertsch vanpertsch Awaiting requested review from vanpertsch

@come-nc come-nc Awaiting requested review from come-nc

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How the limit work if shareId not exists 404 when using GET

3 participants

@skjnldsv @szaimen