CI: Update workflows + remove broken ones #1109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <[email protected]>
…flows
Those workflows were replaced with the filter ("changes") step in the
workflows, so those workflows were blocking some CI runs where the CI
would have been required and lead to false-positive ("green") results.
Signed-off-by: Ferdinand Thiessen <[email protected]>
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
Collaborator
Nice! Thanks a lot for the update of the workflows! 😊 |
szaimen
approved these changes
Jan 13, 2025
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/1109/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 02f9fe8d 211038e4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1109/stable29Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
2 tasks
Member
|
Thanks a lot @susnux - beware that v29 backport failed and is missing (but important to have) |
Contributor
Author
|
@AndyScherzinger the backports are here: |
Member
|
@susnux Could the recent failures of the compile command be related to the workflow updates? Or is it just a coincidence? Thanks! |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those workflows were replaced with the filter ("changes") step in the
workflows, so those workflows were blocking some CI runs where the CI
would have been required and lead to false-positive ("green") results.
You can see #1076 for a false-green "node" ci run. This would have been prevented with this (removing the outdated scripts).