Skip to content

[stable31] Remove custom handling for public share pages with single files #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 4 commits into from
May 6, 2025
Merged

[stable31] Remove custom handling for public share pages with single files #1206

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
152c6ae
fix: Remove custom handling for public share pages with single files
danxuliu Feb 24, 2025
aedb28f
fix: Hide download based on the new WebDAV property
danxuliu Apr 16, 2025
92d1ed7
fix: Open PDF file in "richdocuments" if download is hidden
danxuliu May 6, 2025
2cd6f08
chore(assets): Recompile assets
nextcloud-command May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Open PDF file in "richdocuments" if download is hidden 
Even if the PDF viewer was able to show the file when the download is
hidden, before Nextcloud 31 the custom handling for public shares of a
single file opened it in Nextcloud Office instead. For consistency with
the previous behaviour now Nextcloud Office is used again in that case.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu @szaimen
danxuliu authored and szaimen committed May 6, 2025
commit 92d1ed75881ec5b858322d9dcb5413f10d3acbf7
4 changes: 2 additions & 2 deletions src/views/PDFView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,11 @@ export default {
},

async mounted() {
if (!this.isDownloadable) {
if (!this.isDownloadable || (this.hideDownload && this.isRichDocumentsAvailable)) {
this.doneLoading()

if (this.isRichDocumentsAvailable) {
console.info('PDF file is not downloadable, but "richdocuments" is available, so falling back to it')
console.info('PDF file is not downloadable or has a hidden download, but "richdocuments" is available, so falling back to it')

// Opening the viewer again overwrites its current state, so the
// current options need to be explicitly passed again.
Expand Down