Skip to content

Conversation

@pierluigizagaria
Copy link

Fixed the header and pdf controls overlap as seen in #833

I couldn't reproduce the issue using Chrome's mobile view in DevTools.
To properly test it, I had to connect a physical smartphone via USB in debug mode and use Chrome's remote debugging feature (chrome://inspect).
Only then was I able to observe the issue and debug.

Before

before

After

after

@schnillerman
Copy link

Brilliant ❤️ grandeeee

@szaimen szaimen requested review from danxuliu and juliusknorr June 12, 2025 21:44
@szaimen szaimen added this to the Nextcloud 32 milestone Jun 12, 2025
@pierluigizagaria pierluigizagaria force-pushed the fix/header-pdf-controls-overlap branch from bafa75d to a8cbf1b Compare June 13, 2025 09:30
@pierluigizagaria
Copy link
Author

I've updated the compiled files and force-pushed to keep a single commit

Signed-off-by: pierluigizagaria <[email protected]>
@pierluigizagaria pierluigizagaria force-pushed the fix/header-pdf-controls-overlap branch from a8cbf1b to 40d732d Compare June 17, 2025 17:16
@danxuliu
Copy link
Member

Thanks a lot for your contribution!

While this fix the problem of the overlapping in mobile devices unfortunately it does not fix a subtler one: if you scroll down to the end of the document you will notice, also in mobile devices, that it is "cut" because it overflows the page (due to using vh for the height).

Please find a pull request that hopefully fixes both issues in #1227 Reviews are welcome, of course :-)

I will then close this pull request, but thanks again for your time and for working on a fix for this.

@danxuliu danxuliu closed this Jun 19, 2025
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants