fix(deps): Use correct version of vue-loader #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
added
bug
3. to review
dependencies
Member
Author
|
Actually this app doesn't use vue, so this is not correct. |
Member
Author
|
While it doesn't use vue, it uses the webpack config which checks for the vue-loader version regardless. |
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/deps/vue-loader
branch
from
e3581ec to
ed26326
Compare
AndyScherzinger
approved these changes
Nov 21, 2025
This was referenced Nov 21, 2025
19 tasks
ShGKme
reviewed
Nov 21, 2025
Comment on lines
52
to
+56
| "@nextcloud/webpack-vue-config": "^6.3.0", | ||
| "adm-zip": "^0.5.16", | ||
| "axios": "^1.12.2", | ||
| "cli-progress": "^3.12.0" | ||
| "cli-progress": "^3.12.0", | ||
| "vue-loader": "^15.11.1" |
Contributor
There was a problem hiding this comment.
Instead of direct installing vue-loader I'd propose to use the latest version of @nextcloud/vue-config which doesn't require it anymore
Contributor
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See nextcloud-libraries/webpack-vue-config#688