Disable content copy for PDF files that specify it #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v2.5.207 pdf.js added the "enablePermissions" option to disable copying in the viewer for the PDF files that specify it. The option is off by default, so it needs to be explicitly enabled. Note that the content copy is prevented just by disabling selection through CSS. The "selection disabled" flag in a PDF document is not a strong security measure and can be easily circumvented (for example, just downloading the file and opening it in a PDF reader that does not honour the flag), so disabling the selection through CSS was deemed good enough for pdf.js. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
juliusknorr
approved these changes
Jun 10, 2021
59 tasks
This was referenced Jun 10, 2021
|
The backport to stable19 failed. Please do this backport manually. |
Member
Author
|
Not backported to |
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v2.5.207 pdf.js added the "enablePermissions" option to disable copying in the viewer for the PDF files that specify it. The option is off by default, so it needs to be explicitly enabled.
Note that the content copy is prevented just by disabling selection through CSS. The "selection disabled" flag in a PDF document is not a strong security measure and can be easily circumvented (for example, just downloading the file and opening it in a PDF reader that does not honour the flag), so disabling the selection through CSS was deemed good enough for pdf.js.
How to test
Result with this pull request
The text can not be selected
Result without this pull request
The text can be selected