Skip to content

Conversation

@nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling [email protected]

Signed-off-by: Joas Schilling <[email protected]>
databases: ['sqlite']

name: php${{ matrix.php-versions }}-${{ matrix.databases }}
server-versions: ['stable22']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My using matric is forces to change the tests checks for every branch :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess in this app it doesn't matter. But it becomes a problem if someone does a PR to your PR, because then the base_ref does not exist on server.

Since the "change it on every branch" is automated by nickv-bot I don't mind if you don't

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess in this app it doesn't matter. But it becomes a problem if someone does a PR to your PR, because then the base_ref does not exist on server.

Such a specific use case, it should be fine I think :)
In any case, how do you manage all those branchs checks differences in the github branch protection?
One rule per stable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most apps protect stable[0-9][0-9]

@nickvergessen nickvergessen merged commit 91fb3c9 into stable22 Jun 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-stable22-target-versions branch June 29, 2021 11:21
@blizzz blizzz mentioned this pull request Jun 30, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants