[stable26] Fix extraction of PDF.js package #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that in some cases "unzipper" may not extract all the files and, with some node versions, it may corrupt some of the extracted files. As there is no fix for all that yet (downgrading "unzipper" to 0.10.11 might solve the missing extracted files, but it would still be affected by the corrupted files and thus prevent upgrading to a newer node version) "unzipper" was replaced by "adm-zip". "adm-zip" does not have dependencies and has a large user base. Unfortunately it does not support streams and requires loading the whole file in memory to be able to extract it, but the package is not very large (around 5,5 MiB), so this should not be a problem. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
bug
3. to review
dependencies
szaimen
approved these changes
Aug 21, 2023
delete-merged-branch
bot
deleted the
backport/806/stable26-fix-extraction-of-pdf.js-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #806
This also adds back the files deleted after rebuilding when unzipper version was bumped