fix pdf-viewer sizing #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
force-pushed
the
enh/843/fix-sizing
branch
from
6da497e to
f22be1f
Compare
danxuliu
previously requested changes
Oct 28, 2023
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Blocking at least until nextcloud/viewer#2030 is clarified.
szaimen
force-pushed
the
enh/843/fix-sizing
branch
from
f22be1f to
826ee23
Compare
Member
|
How does it behaves with the sidebar or other menus? |
Collaborator
Author
Works: |
szaimen
requested review from
danxuliu,
juliusknorr and
skjnldsv
and removed request for
danxuliu,
juliusknorr and
skjnldsv
szaimen
force-pushed
the
enh/843/fix-sizing
branch
from
826ee23 to
9fd49e2
Compare
Collaborator
Author
|
/compile |
Signed-off-by: Simon L <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
enh/843/fix-sizing
branch
from
9fd49e2 to
a9c11bc
Compare
danxuliu
reviewed
Nov 3, 2023
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
I am late to the party, but... tested and works 👍
Nice fix :-D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #843