Skip to content
This repository was archived by the owner on May 21, 2024. It is now read-only.

fix multiselect right-click options #152

Merged
szaimen merged 1 commit into from
Mar 17, 2023
Merged

fix multiselect right-click options #152

szaimen merged 1 commit into from
Mar 17, 2023

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Mar 17, 2023 •
edited
Loading

To reproduce:

  1. share a folder with a user anna
  2. remove the delete permission
  3. open the folder with the user anna
  4. multi-select the file
  5. see the delete option even though there are no delete permissions
Before After
image image
For my own testing 
docker run -it \
--name nextcloud-easy-test \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.24.128 \
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
-e SERVER_BRANCH=master \
-e RIGHTCLICK_BRANCH=enh/noid/fix-multiselect-right-click \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added the 2. developing Work in progress label Mar 17, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone Mar 17, 2023
@szaimen szaimen added bug Something isn't working 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 17, 2023
@szaimen szaimen requested review from Pytal and artonge March 17, 2023 14:09
@szaimen szaimen marked this pull request as ready for review March 17, 2023 14:09
@szaimen
Copy link
Contributor Author

szaimen commented Mar 17, 2023

CI failure unrelated

@szaimen
Copy link
Contributor Author

szaimen commented Mar 17, 2023

/backport to stable26

@szaimen
Copy link
Contributor Author

szaimen commented Mar 17, 2023

/backport to stable25

@szaimen
Copy link
Contributor Author

szaimen commented Mar 17, 2023

/backport to stable24

@szaimen
Copy link
Contributor Author

szaimen commented Mar 17, 2023

Thanks Chris! :)

@szaimen szaimen merged commit 086c251 into master Mar 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/fix-multiselect-right-click branch March 17, 2023 14:24
This was referenced Mar 17, 2023
Merged
Merged
Merged
This was referenced Mar 18, 2023
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@artonge artonge Awaiting requested review from artonge

1 more reviewer

@Pytal Pytal Pytal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

3 participants

@szaimen @Pytal