Skip to content

Improve code blocks in markdown rendering #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 3 commits into from
Oct 23, 2018
Merged

Improve code blocks in markdown rendering #120

MorrisJobke merged 3 commits into from
Oct 23, 2018

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Oct 16, 2018

Before:

bildschirmfoto 2018-10-16 um 14 04 45

After:

bildschirmfoto 2018-10-16 um 14 04 24

@MorrisJobke MorrisJobke added this to the Nextcloud 15 milestone Oct 16, 2018
rullzer
rullzer approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Oct 16, 2018

I also added some margin bottom to the details sections:

Before:
bildschirmfoto 2018-10-16 um 14 12 56

After:

bildschirmfoto 2018-10-16 um 14 12 20

juliusknorr
juliusknorr reviewed Oct 16, 2018
View reviewed changes
css/public-share.scss Outdated
code {
background-color: rgb(242, 242, 242);
border-radius: 3px;
padding: 0px 2px 2px 2px;
Copy link
Member

@juliusknorr juliusknorr Oct 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some padding on the left (maybe a bit more in general) would be good I think. Besides that 👍

Copy link
Member Author

@MorrisJobke MorrisJobke Oct 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bildschirmfoto 2018-10-16 um 14 36 15

Done

@MorrisJobke MorrisJobke merged commit 97f01c3 into master Oct 23, 2018
@MorrisJobke MorrisJobke deleted the bugfix/noid/properly-show-markdown-code branch October 23, 2018 12:34
@MorrisJobke MorrisJobke mentioned this pull request Oct 23, 2018
Merged
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Oct 23, 2018

Backport in #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr left review comments

@rullzer rullzer rullzer approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

No one assigned

Labels

4. to release

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

5 participants

@MorrisJobke @rullzer @juliusknorr @skjnldsv