Darken background, adjust to new modal component #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
jancborchardt
requested review from
icewind1991,
juliusknorr,
rullzer and
skjnldsv
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
Member
Author
|
While I’m at it I also fixed the border-radius: |
skjnldsv
approved these changes
Mar 13, 2019
Member
Author
|
Both signed off and it’s only CSS, so Drone failure seems irrelevant? |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust to the 85% black we also will use for the new Modal, ref nextcloud-libraries/nextcloud-vue#300
Please review @nextcloud/designers
Before & after: