Skip to content

Translate menu action #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 2 commits into from
Sep 5, 2019
Merged

Translate menu action #180

juliusknorr merged 2 commits into from
Sep 5, 2019

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 2, 2019

Fix #179

@skjnldsv skjnldsv self-assigned this Sep 2, 2019
juliusknorr
juliusknorr reviewed Sep 2, 2019
View reviewed changes
package.json
"dependencies": {
"brace": "^0.11.1",
"marked": "^0.6.2"
"marked": "^0.7.0"
Copy link
Member

@juliusknorr juliusknorr Sep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done separately in #170

Copy link
Member Author

@skjnldsv skjnldsv Sep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there was some audit issues, I decided to fix while at it :)

@skjnldsv @rullzer
Translate menu action
02953b6 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@rullzer rullzer force-pushed the fix/action/translation branch from c497910 to 02953b6 Compare September 3, 2019 11:22
@juliusknorr
Copy link
Member

juliusknorr commented Sep 4, 2019

/compile /js

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 4, 2019

/compile /js

95 | modified: build/editor.js
96 | modified: build/editor.js.map
97 | modified: build/public-share.js
98 | modified: build/public-share.js.map

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 4, 2019

/compile /build

@npmbuildbot
Compile assets
1e727fb 
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@juliusknorr juliusknorr merged commit 7932907 into master Sep 5, 2019
@juliusknorr juliusknorr deleted the fix/action/translation branch September 5, 2019 12:38
@juliusknorr juliusknorr mentioned this pull request Sep 5, 2019
Merged
@juliusknorr
Copy link
Member

juliusknorr commented Sep 6, 2019

/backport to stable16

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 6, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Sep 6, 2019

backport to stable16 in #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer rullzer approved these changes

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

@skjnldsv skjnldsv

Labels

3. to review bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Context menu entry not translated

5 participants

@skjnldsv @juliusknorr @rullzer @tobiasKaminsky