This repository was archived by the owner on May 28, 2024. It is now read-only.
Ignore query arguments in single video share for stable15 (Fix #121) #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same fix as commit 4da10ee for stable15 Signed-off-by: Mathieu Débit <[email protected]>
MathieuDebit
force-pushed
the
stable15-fix-ignore-query-arguments-video
branch
from
b214f85 to
27dfbd3
Compare
juliusknorr
suggested changes
Mar 20, 2019
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Looks good except for the version bump.
appinfo/info.xml
Outdated
| Skin: https://github.com/cabin/videojs-sublime-skin | ||
| </description> | ||
| <version>1.4.0</version> | ||
| <version>1.4.1</version> |
Member
There was a problem hiding this comment.
No need to bump the version in this PR.
Signed-off-by: Mathieu Débit <[email protected]>
MathieuDebit
force-pushed
the
stable15-fix-ignore-query-arguments-video
branch
from
05a2490 to
b473b04
Compare
Author
|
@juliushaertl I updated the PR 👌 |
juliusknorr
approved these changes
Mar 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same fix as commit 4da10ee but for
stable15. See #121.I'm not sure to know how to contribute here so tell me if it's good 🙏