Fix button labels in dialog #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dialog to enter a name for the compressed file is based in a standard "OC.dialogs.prompt", but with some adjustments, like the button labels. The adjustment relies on the whole dialog containing only two buttons (those from the button row), which was true in the past. However, due to the accesibility fixes the dialog now contains an extra button to close the dialog, which alters the expected order of the buttons to modify and causes the labels to be wrongly assigned. To fix that the query to select the buttons to modify is restricted only to those in the button row, which behaves as expected in the whole range of supported versions (from Nextcloud 22 to Nextcloud 27). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
juliusknorr
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dialog to enter a name for the compressed file is based in a standard
OC.dialogs.prompt, but with some adjustments, like the button labels. The adjustment relies on the whole dialog containing only two buttons (those from the button row), which was true in the past. However, due to the accesibility fixes the dialog now (Nextcloud >= 25.0.5, 26.0.0 and master) contains an extra button to close the dialog, which alters the expected order of the buttons to modify and causes the labels to be wrongly assigned.To fix that the query to select the buttons to modify is restricted only to those in the button row, which behaves as expected in the whole range of supported versions (from Nextcloud 22 to Nextcloud 27).
🖼️ Screenshots
How to test
Result with this pull request
The buttons in the button row are labeled Cancel and Compress files
Result without this pull request
The buttons in the button row are labeled Compress files and Yes, and the close button is labeled Cancel, which overflows its boundaries