Skip to content

Clean up any temp files after each job #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 1 commit into from
May 31, 2022
Merged

Clean up any temp files after each job #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/BackgroundJob/ZipJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
use OCA\FilesZip\Service\ZipService;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\BackgroundJob\QueuedJob;
use OCP\ITempManager;
use Psr\Log\LoggerInterface;

class ZipJob extends QueuedJob {
Expand All @@ -40,12 +41,15 @@ class ZipJob extends QueuedJob {
private $notificationService;
/** @var LoggerInterface */
private $logger;
/** @var ITempManager */
private $tempManager;

public function __construct(ITimeFactory $timeFactory, ZipService $zipService, NotificationService $notificationService, LoggerInterface $logger) {
public function __construct(ITimeFactory $timeFactory, ZipService $zipService, NotificationService $notificationService, LoggerInterface $logger, ITempManager $tempManager) {
parent::__construct($timeFactory);
$this->zipService = $zipService;
$this->notificationService = $notificationService;
$this->logger = $logger;
$this->tempManager = $tempManager;
}

public function getUid(): string {
Expand All @@ -67,6 +71,8 @@ protected function run($argument) {
} catch (\Throwable $e) {
$this->logger->error('Failed to create zip archive', ['exception' => $e]);
$this->notificationService->sendNotificationOnFailure($this);
} finally {
$this->tempManager->clean();
}
}
}