Migrate personal setting page to vue #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/personal-settings
branch
from
6495c8e to
d8c0daa
Compare
szaimen
reviewed
Jun 19, 2024
Collaborator
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
I tested it and it looks mostly fine but I noticed two things:
- the icon has the wrong color
- the server address does not seem to be correct
This was referenced Jul 30, 2024
susnux
force-pushed
the
fix/personal-settings
branch
2 times, most recently
from
d77405e to
9a67218
Compare
Collaborator
|
I just tested this again.
This is still the case but the other issue seems to be fixed :) However this button does not seem to work: |
susnux
force-pushed
the
fix/personal-settings
branch
from
9a67218 to
2b25d8e
Compare
Contributor
Author
|
@szaimen both issues should be now resolved |
szaimen
approved these changes
Aug 8, 2024
Collaborator
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Just tested again and works :)
But didnt review the code
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/personal-settings
branch
from
2b25d8e to
da7c782
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/personal-settings
branch
from
da7c782 to
8214741
Compare
Contributor
Author
|
/backport to stable29 |
2 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page was using a removed script, so I ported it to vue completly.
But maybe this better belongs to server core?