fix: Add app hint for whiteboard #1353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
requested review from
Pytal,
hweihwang,
jancborchardt and
szaimen
hweihwang
approved these changes
Sep 12, 2024
Member
|
needs a backport to stable30 i suppose? |
| break; | ||
| case 'whiteboard': | ||
| $notification->setParsedSubject($l->t('App recommendation: Whiteboard')); | ||
| $notification->setParsedMessage($l->t('Create and share whiteboards with other users and collaborate in real-time.')); |
Member
There was a problem hiding this comment.
Not a big deal but FYI @juliushaertl we want to avoid the word "user" and thus it could be simplified to:
Create and share whiteboards with others and collaborate in real-time.
Member
Author
There was a problem hiding this comment.
Sure, #1354 will cherry pick that to the backport
Member
Author
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an app hint for the whiteboard app
Contributes to nextcloud/whiteboard#99