Fix design of settings page #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Talk settings part at nextcloud/spreed#2662 |
juliusknorr
approved these changes
Jan 3, 2020
Member
|
@jancborchardt Please rebase to current master to get green CI |
skjnldsv
approved these changes
Jan 3, 2020
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
jancborchardt
force-pushed
the
design/settings
branch
from
e58cb1c to
074814c
Compare
Member
Author
Ah thanks, rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: Jumbled mess :D
After: Actually using the proper
.sectionclass we use in settings:Please review @nextcloud/designers @GretaD @juliushaertl