Skip to content

[stable19] Do not keep loading the slide list on every reopen #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 1 commit into from
Jul 2, 2020
Merged

[stable19] Do not keep loading the slide list on every reopen #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Do not keep loading the slide list on every reopen 
Loading the slide list once was more than enough.

Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
  • Loading branch information
@rullzer @npmbuildbot
rullzer authored and npmbuildbot[bot] committed Jul 2, 2020
commit 75d76c1ac07e5f17173ed79aa9a64a36c0d01003
2 changes: 1 addition & 1 deletion js/firstrunwizard.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/firstrunwizard.js.map
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,7 @@ export default {
currentSlide: 0,
fadeDirection: 'next',
isMobile: window.outerWidth < 1024,
slidesLoaded: false,
}
},
computed: {
Expand Down Expand Up @@ -376,9 +377,14 @@ export default {
},
methods: {
async loadStaticSlides() {
if (this.slidesLoaded) {
return
}

try {
const response = await axios.get(generateUrl('/apps/firstrunwizard/wizard'))
this.slides.push(...response.data)
this.slidesLoaded = true
} catch (e) {
console.error('Failed to load slides')
}
Expand Down