link to nextcloud.com and not the cloud itself #564
Conversation
templates/page.values.php
Outdated
| </ul> | ||
|
|
||
| <p class="details-link"><a href="<?php p($theme->getBaseUrl()); ?>" target="_blank" rel="noreferrer noopener"><?php p($l->t('Learn more about %s', $theme->getName())); ?></a></p> | ||
| <p class="details-link"><a href="https://nextcloud.com" target="_blank" rel="noreferrer noopener"><?php p($l->t('Learn more about Nextcloud')); ?></a></p> |
There was a problem hiding this comment.
Please use https://github.com/nextcloud/server/blob/3860dad9eaac937288d125c75e7f58cfbe44848a/lib/public/Defaults.php#L130 for the product name which would allow to specify the software. For the product url we currently don't have anything to replace, but we might need to have that adaptable for service provider scenarios.
There was a problem hiding this comment.
the first part is done, the second for specifying the url is not
There was a problem hiding this comment.
For the product url we currently don't have anything to replace, but we might need to have that adaptable for service provider scenarios.
Any idea how to do that?
szaimen
force-pushed
the
enh/462/link-to-nextcloud.com
branch
from
8d6a389 to
e878b85
Compare
|
Failing test seems unrelated to me |
Signed-off-by: szaimen <[email protected]> Co-Authored-By: Julius Härtl <[email protected]>
szaimen
force-pushed
the
enh/462/link-to-nextcloud.com
branch
from
c5efbd1 to
2437626
Compare
|
I'll do that again. |
|
Superseded by #567 |
Fix #462
Signed-off-by: szaimen [email protected]