Skip to content

fix overlapping buttons #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 2 commits into from
Dec 20, 2021
Merged

fix overlapping buttons #651

juliusknorr merged 2 commits into from
Dec 20, 2021

Conversation

@szaimen
Copy link
Collaborator

@szaimen szaimen commented Dec 17, 2021 •
edited
Loading

This is best reviewed like this: https://github.com/nextcloud/firstrunwizard/pull/651/files?diff=unified&w=1

Desktop

Before After
image image

Mobile

Before After
image image

Signed-off-by: szaimen [email protected]

For my own testing 
docker run -it \
-e FIRSTRUNWIZARD_BRANCH=enh/noid/fix-overlapping-buttons \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen force-pushed the enh/noid/fix-overlapping-buttons branch 4 times, most recently from 5ffff2c to b7f3bd0 Compare December 17, 2021 22:07
@szaimen
Copy link
Collaborator Author

szaimen commented Dec 17, 2021

/compile amend /

@szaimen szaimen added this to the Nextcloud 24 milestone Dec 17, 2021
@szaimen
Copy link
Collaborator Author

szaimen commented Dec 17, 2021

/backport to stable23

@szaimen
Copy link
Collaborator Author

szaimen commented Dec 17, 2021

/backport to stable22

@szaimen szaimen marked this pull request as ready for review December 17, 2021 22:16
@szaimen @nextcloud-command
fix overlapping buttons
21c21a4 
Signed-off-by: szaimen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the enh/noid/fix-overlapping-buttons branch from b7f3bd0 to 21c21a4 Compare December 17, 2021 22:16
skjnldsv
skjnldsv approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fod of the migration of the primary button to the left. I would have maybe made the main content scrollable/shrinkable and the button fixed at the bottom 🤔

@szaimen
Copy link
Collaborator Author

szaimen commented Dec 20, 2021

Not fod of the migration of the primary button to the left.

Just pushed a new commit that switches the sides which is a good solution as well, imo.

Please have a look at the updated screenshots :)

@szaimen
Copy link
Collaborator Author

szaimen commented Dec 20, 2021

/compile amend /

@nextcloud-command nextcloud-command force-pushed the enh/noid/fix-overlapping-buttons branch from afd8ebf to cd88070 Compare December 20, 2021 10:20
@szaimen
Copy link
Collaborator Author

szaimen commented Dec 20, 2021

/backport to stable21

@juliusknorr juliusknorr merged commit 7d8a0fc into master Dec 20, 2021
@juliusknorr juliusknorr deleted the enh/noid/fix-overlapping-buttons branch December 20, 2021 12:32
This was referenced Dec 20, 2021
Merged
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

No one assigned

Labels

4. to release design enhancement

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

4 participants

@szaimen @juliusknorr @skjnldsv