make buttons edgy on mobile

[szaimen]

This is best reviewed like this: https://github.com/nextcloud/firstrunwizard/pull/698/files?diff=unified&w=1

Reason for this: I think edgy buttons look better for mobile:

Before	After

Signed-off-by: szaimen [email protected]

For my own testing

docker run -it \
-e FIRSTRUNWIZARD_BRANCH=enh/noid/make-buttons-edgy-on-mobile \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

[szaimen]

/compile amend /

[artonge]

Code looks good. But let's wait for the design team input before merging.

[szaimen]

/compile amend /

[jancborchardt]

Reason for this: I think edgy buttons look better for mobile

:D love the reasoning.

Counter-proposal: We keep the circular buttons, but on mobile we move them to the bottom, with a bit of whitespace to the bottom and each of the sides respectively. Kind of like an Android FAB, but on both sides. Also easier to reach for fingers.

[szaimen]

Counter-proposal: We keep the circular buttons, but on mobile we move them to the bottom, with a bit of whitespace to the bottom and each of the sides respectively. Kind of like an Android FAB, but on both sides. Also easier to reach for fingers.

Prpblem with moving it to the bottom is that the buttons will overlap the content and other buttons in the templates which looks really weird, in my opinion. That is why they are positioned where they are currently...

[szaimen]

@jancborchardt what is your take on this?

Prpblem with moving it to the bottom is that the buttons will overlap the content and other buttons in the templates which looks really weird, in my opinion. That is why they are positioned where they are currently...

[nimishavijay]

Looks interesting!
Most of our buttons are round (or have a pill-shape) so I'm wondering if it would be consistent with our designs 🤔

[szaimen]

Looks interesting! Most of our buttons are round (or have a pill-shape) so I'm wondering if it would be consistent with our designs 🤔

Not sure. Please decide and let me know to merge or to close :)

[szaimen]

I am fine with any decision but I need a decision here :)

[nimishavijay]

I would keep the circular buttons, it is consistent with our style :)

[szaimen]

I would keep the circular buttons, it is consistent with our style :)

okay 👍

[jancborchardt]

Sorry for late reply @szaimen · regardong the overlap issue, we can make sure that if left/right controls are present, that on mobile there's room for them below the modal?